-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit columns added to strategies panel table #247
Conversation
Please note that I changed the tooltip verbiage to read
In our scrum , "Please select fewer than 80 columns" was suggested, but since 80 columns is allowable, I tweaked the verbiage accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, save for the minor formatting issue. Once that is addressed, I think this is good to go.
const updateButton = ( | ||
<button | ||
type="button" | ||
className="btn" | ||
disabled={areMaxColumnsExceeded ? true : false} | ||
onClick={() => { | ||
if (columnsDialogSelection) { | ||
requestColumnsChoiceUpdate(columnsDialogSelection, question.urlSegment) | ||
} | ||
showHideAddColumnsDialog(false); | ||
}} | ||
> | ||
Update Columns | ||
</button> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation here is a little off.
Resolves #246
Follow up work that improves the UI of the modal will be handled when replacing the existing WDKClient
CheckboxTree
with the new version from CoreUI, as outlined in #248.